Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misspellings identified by the check-spelling action.
Split from #7507 - the sqlserver parts per #7507 (comment)
Required for all PRs:
Signed CLA.
Associated README.md updated. -- I'm going to wait for someone to review this before I take this step. Note that CONTRIBUTING.md makes no mention of this.
Has appropriate unit tests. -- Not included, but available (note that it wouldn't be a make thing, although I suppose I could create a Docker for it... that seems pretty doable -- people have asked for a way to do that...):
It reported: jsoref@25d89f6#commitcomment-39074475
And it validated that the changes in this PR made it happy: jsoref@95180ce
Some projects like to rebase, some to squash, some ask for things to be split up. I try to avoid doing anything until a reviewer provides direction. It's much easier for me to initially work with individual commits (e.g. there are some en-US commits here, if you tell me your project is en-GB, I can easily drop them today, but if I squash eagerly, then disentangling them can be painful). I'm happy to make changes/follow directions within reason.