Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling - sqlserver #7524

Merged
merged 4 commits into from
May 22, 2020
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 15, 2020

Misspellings identified by the check-spelling action.

Split from #7507 - the sqlserver parts per #7507 (comment)

Required for all PRs:

  • Signed CLA.

  • Associated README.md updated. -- I'm going to wait for someone to review this before I take this step. Note that CONTRIBUTING.md makes no mention of this.

  • Has appropriate unit tests. -- Not included, but available (note that it wouldn't be a make thing, although I suppose I could create a Docker for it... that seems pretty doable -- people have asked for a way to do that...):

    It reported: jsoref@25d89f6#commitcomment-39074475

    And it validated that the changes in this PR made it happy: jsoref@95180ce


Some projects like to rebase, some to squash, some ask for things to be split up. I try to avoid doing anything until a reviewer provides direction. It's much easier for me to initially work with individual commits (e.g. there are some en-US commits here, if you tell me your project is en-GB, I can easily drop them today, but if I squash eagerly, then disentangling them can be painful). I'm happy to make changes/follow directions within reason.

@jsoref
Copy link
Contributor Author

jsoref commented May 15, 2020

@Trovalo

@Trovalo
Copy link
Collaborator

Trovalo commented May 16, 2020

Here is the list of the impacts:

  • Preemptive CPU Usage (time) - field key, no impact (it's never extracted in any case because of the query itself (bug), therefore it won't break anything)
  • total_elapsed_time_ms - field key, will change measurement structure
  • HADR_FILESTREAM_IOMGR_IOCOMPLETION - this fixes the version 1 of SQL Server queries, as a result. points with tag wait_type "HADR_FILESTREAM_IOMGR_IOCOMPLETION" will be excluded in the final result (it's not a relevant wait stat)
  • PVTTable - internal name never exposed, no impact

To me this can be approved

@danielnelson danielnelson added this to the 1.15.0 milestone May 22, 2020
@danielnelson danielnelson merged commit f975b94 into influxdata:master May 22, 2020
@jsoref jsoref deleted the spelling-sqlserver branch May 22, 2020 17:10
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants