Ensure metrics generated are correct in ping plugin using "native" #6563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
suggested changes
Oct 22, 2019
danielnelson
approved these changes
Oct 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
…nfluxdata#6563) (cherry picked from commit c1521b5)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when using raw socket mode with
method = "native"on the ping input plugin where responses would be processed for the wrong host. This has been rectified upstream and the library updated in telegraf.Better matching in
result_codehas also been implemented in telegraf betweenexecandnativemethods.Resolves #6521