Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite - allow to silently skip infinity and NaN values #6415

Closed
piotrp opened this issue Sep 18, 2019 · 0 comments · Fixed by #6420
Closed

Graphite - allow to silently skip infinity and NaN values #6415

piotrp opened this issue Sep 18, 2019 · 0 comments · Fixed by #6420
Assignees
Labels
feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@piotrp
Copy link

piotrp commented Sep 18, 2019

Feature Request

Allow Graphite parser to silently ignore values that are supported by Graphite but unsupported by InfluxDB (NaN, infinity).

Proposal:

Introduce a flag that would allow to drop these values without writing anything to log.

Current behavior:

Parser logs an error after encountering such value:

if math.IsNaN(v) || math.IsInf(v, 0) {
return nil, &UnsupposedValueError{Field: fields[0], Value: v}
}

Desired behavior:

Silently drop infinity and NaN values (Inf, -Inf, NaN, Infinity, -Infinity). They are already properly parsed, but currently log an error.

Use case:

I want to process some Graphite metrics in Telegraf and pass them to InfluxDB, but currently Telegraf generates an error message to system journal for each dropped metric value, resulting in an unacceptable amount of logs.

@danielnelson danielnelson self-assigned this Sep 18, 2019
@danielnelson danielnelson added the feature request Requests for new plugin and for new features to existing plugins label Sep 18, 2019
@danielnelson danielnelson added this to the 1.13.0 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants