Add topic_tag option to mqtt_consumer #6266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
the
feat
glinton
approved these changes
Aug 19, 2019
| @@ -18,6 +18,10 @@ and creates metrics using one of the supported [input data formats][]. | |||
| "sensors/#", | |||
| ] | |||
|
|
|||
| ## The message topic will be stored in a tag specified by this value. If set | |||
| ## to the empty string no topic tag will be created. | |||
There was a problem hiding this comment.
s/to the empty string/to an empty string,/ reads better
There was a problem hiding this comment.
There is only one empty string, generally referred to as the empty string. Check out the usage here: https://en.wikipedia.org/wiki/Empty_string
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option
topic_tagto the mqtt_consumer input. When unset the default istopicin order to preserve backwards compatibility, when set to""no topic tag is added, otherwise the value is used for the topic tag. This is the basic pattern I would like to use for all inputs with parsers and want to add metadata.In 2.0 we should change the default to not add the topic tag. We don't have a mechanism for changing the defaults yet, this is something that needs a plan.
closes: #6262
Required for all PRs: