Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some inconsistencies in object selection and path parsing #6243

Closed
wants to merge 65 commits into from
Closed

Fixed some inconsistencies in object selection and path parsing #6243

wants to merge 65 commits into from

Conversation

prydin
Copy link
Contributor

@prydin prydin commented Aug 12, 2019

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This PR fixes some issues and inconsistencies in vSphere inventory object selection using path (vm_include, etc.). Specifically, it addresses the following:

This is a bugfix PR.

* Don't stop collection on partial error
* Compute average if query returned multiple samples for a metric
…g from GetClient(), fixed discovered object counting
@prydin
Copy link
Contributor Author

prydin commented Aug 12, 2019

Wrong branch. Ignore this PR!

@prydin prydin closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant