-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional namespace restriction to prometheus input plugin #5697
Conversation
…permissions Signed-off-by: David Timm <[email protected]>
We see that there was a previous issue about this. Seeing their solution, it seems like it could be reasonable/convenient to have it be a toggle and ONLY apply to the namespace of the telegraf config, but we also think the usecases that this supports are wider. |
We seem to be having failed tests unrelated to our changes.. I tried to close/open this pr to run the tests again, this does not seem to re-run tests. |
Signed-off-by: Ben Fuller <[email protected]>
Done! Although we notice monitor_kubernetes_pods is set to true here, which I do not believe is the default. |
Thanks, I'll switch that option after we merge this. I don't see your github name in our records as having signed the CLA, could you sign it? If you already signed, sorry something didn't work, its okay to do it again. |
I believe we should be on the pivotal corporate cla. I'm double checking some stuff though as well. |
I don't see a completed CCLA for Pivotal on my side either, but even so it is also required to do the individual CLA. There is a more info on needing both here: https://www.influxdata.com/legal/ccla/ |
Ok, I should have just signed the individual cla. |
Allow prometheus to operate as a namespaced pod with namespace level permissions. This addresses #5306
Required for all PRs: