Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance error log when dns query isn't successful #5417

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Enhance error log when dns query isn't successful #5417

merged 3 commits into from
Feb 13, 2019

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Feb 12, 2019

Resolves #5276

From what I see it's always been creating a metric with the result and result_code, but I've enhanced the logging to give more information:

2019-02-12T15:41:12Z E! [inputs.dns_query]: Error in plugin: Invalid answer (NXDOMAIN) from 127.0.0.1 after A query for definitelynotreal.com
dns_query,domain=definitelynotreal.com,record_type=A,result=error,server=127.0.0.1 result_code=2i 1549986072000000000
dns_query,domain=google.com,record_type=A,result=success,server=127.0.0.1 result_code=0i,query_time_ms=0.440704 1549986072000000000

@glinton glinton added the fix pr to fix corresponding bug label Feb 12, 2019
@glinton glinton added this to the 1.10.0 milestone Feb 12, 2019
@danielnelson
Copy link
Contributor

Can you update the readme too?

@danielnelson danielnelson merged commit 3e9703a into master Feb 13, 2019
@danielnelson danielnelson deleted the bugfix/5276 branch February 13, 2019 01:57
@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin and removed fix pr to fix corresponding bug labels Feb 13, 2019
@danielnelson danielnelson mentioned this pull request Feb 13, 2019
Closed
trevorwhitney pushed a commit to trevorwhitney/telegraf that referenced this pull request Feb 14, 2019
@glinton
Add rcode tag and field to dns_query input (influxdata#5417)
45c880f
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@glinton @otherpirate
Add rcode tag and field to dns_query input (influxdata#5417)
d026865
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@glinton @otherpirate
Add rcode tag and field to dns_query input (influxdata#5417)
f9acb2b
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
@glinton
Add rcode tag and field to dns_query input (influxdata#5417)
7daa9dc
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@glinton @bitcharmer
Add rcode tag and field to dns_query input (influxdata#5417)
57307d3
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@glinton
Add rcode tag and field to dns_query input (influxdata#5417)
bc082fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@glinton @danielnelson