Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the buffer_size internal metric after writes #5314

Merged
merged 2 commits into from
Jan 22, 2019

Conversation

danielnelson
Copy link
Contributor

Update the internal_write buffer_size metric immediately when a metric is added and after a successful write. Includes a fix for metric buffer changes on master that can cause a panic.

closes #5298

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added fix pr to fix corresponding bug area/agent labels Jan 18, 2019
@danielnelson danielnelson added this to the 1.9.3 milestone Jan 18, 2019
@danielnelson danielnelson merged commit b34c5e0 into master Jan 22, 2019
@danielnelson danielnelson deleted the metric-buffer-part-2 branch January 22, 2019 21:43
danielnelson added a commit that referenced this pull request Jan 22, 2019
trevorwhitney pushed a commit to trevorwhitney/telegraf that referenced this pull request Feb 14, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal_write.buffer_size metric not reset on timed writes
2 participants