Change from INFO to INFO ALL to get Commandstats statistics) #2894 #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta#2894 Added tests for influxdata#2894 Added documentation for influxdata#2894
danielnelson
suggested changes
Jun 9, 2017
| if section == "Commandstats" { | ||
| //#cmdstat_get:calls=63102137,usec=166854619,usec_per_call=2.64 | ||
| tmp := strings.Split(line, ":") | ||
| tmp_metrics := strings.Split(tmp[1], ",") |
There was a problem hiding this comment.
Check for the length of the splits before indexing, just in case the input is bad for some reason. In the case of not having a ":", call acc.AddError and continue.
| tmp := strings.Split(line, ":") | ||
| tmp_metrics := strings.Split(tmp[1], ",") | ||
| for _, element := range tmp_metrics { | ||
| mdata := strings.Split(element, "=") |
phemmer
reviewed
Jun 9, 2017
| for _, element := range tmp_metrics { | ||
| mdata := strings.Split(element, "=") | ||
| if ival, err := strconv.ParseInt(mdata[1], 10, 64); err == nil { | ||
| fields[tmp[0]+mdata[0]] = ival |
There was a problem hiding this comment.
I think it would be good to separate tmp[0] & mdata[0] with a delimiter, such as _.
danielnelson
added
area/redis
feat
…influxdata-master
|
@marek-knappe do you have time soon to address the feedback from daniel and phemmer? |
3 tasks
|
Closing, addressed in PR #5926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for #2894
Added documentation for #2894
Required for all PRs: