Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.nats_consumer): Add nkey-seed-file authentication #14375

Merged
merged 2 commits into from
Dec 4, 2023
Merged

feat(inputs.nats_consumer): Add nkey-seed-file authentication #14375

merged 2 commits into from
Dec 4, 2023

Conversation

jxlxx
Copy link
Contributor

@jxlxx jxlxx commented Dec 1, 2023 •
edited
Loading

Summary

This PR makes it possible for the nats_consumer input plugin to authenticate with NATS via an nkey seed file.

Checklist

  • Updated associated README.md

  • Pull request title or commits are in conventional commit format

  • No AI generated code was used in this PR

Related issues

resolves #14374

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 1, 2023
@jxlxx jxlxx marked this pull request as draft December 1, 2023 20:17
@jxlxx jxlxx marked this pull request as ready for review December 1, 2023 23:22
powersj
powersj reviewed Dec 2, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature request + PR, just a couple comments!

plugins/inputs/nats_consumer/README.md Outdated Show resolved Hide resolved
plugins/inputs/nats_consumer/README.md Outdated Show resolved Hide resolved
plugins/inputs/nats_consumer/nats_consumer.go Show resolved Hide resolved
@powersj powersj self-assigned this Dec 2, 2023
powersj
powersj approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 4, 2023
@powersj powersj assigned srebhan and unassigned powersj Dec 4, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 4, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan changed the title feat(inputs.nats_consumer): added nkey seed file auth support feat(inputs.nats_consumer): Add nkey seed file auth support Dec 4, 2023
@srebhan srebhan changed the title feat(inputs.nats_consumer): Add nkey seed file auth support feat(inputs.nats_consumer): Add nkey-seed-file authentication Dec 4, 2023
srebhan
srebhan approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @jxlxx!

@srebhan srebhan merged commit f3c52dc into influxdata:master Dec 4, 2023
25 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Dec 4, 2023
@Porkepix Porkepix mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging this pull request may close these issues.

inputs.nats_consumer: Add nkey static config support to nats_consumer input plugin
3 participants
@jxlxx @powersj @srebhan