Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/showwin/speedtest-go from 1.5.2 to 1.6.2 #13369

Merged
merged 6 commits into from
Jun 1, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented May 31, 2023

This PR updates the speedtest-go package to get the fix showwin/speedtest-go#127. Without this, Telegraf will discard all log messages after the inputs.internet_speed plugin is imported due to a log.SetOutput(io.Discard) call in that package.

@telegraf-tiger telegraf-tiger bot added the chore label May 31, 2023
@srebhan srebhan added the dependencies Pull requests that update a dependency file label May 31, 2023
@srebhan
Copy link
Member Author

srebhan commented May 31, 2023

@r3inbowari can you please check if my changes to the plugin are correct!?

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 31, 2023
go.mod Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
plugins/inputs/internet_speed/internet_speed.go Outdated Show resolved Hide resolved
@r3inbowari
Copy link
Contributor

@r3inbowari can you please check if my changes to the plugin are correct!?

OK, @srebhan, i left some comments.

@powersj powersj changed the title chore(deps): Bump github.com/showwin/speedtest-go from 1.5.2 to 1.6.1 chore(deps): Bump github.com/showwin/speedtest-go from 1.5.2 to 1.6.2 May 31, 2023
powersj and others added 3 commits May 31, 2023 11:07
@srebhan srebhan merged commit 2be423a into influxdata:master Jun 1, 2023
@srebhan srebhan deleted the fix_log_discard branch June 1, 2023 09:34
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Import of this package will destroy logging
3 participants