Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regression in temps introduced by gopsutil update #11301

Closed
wants to merge 10 commits into from

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jun 14, 2022

resolves #11294

This PR brings back critical (_crit) and high (_max) temperature levels lost during a gopsutil update. We cannot restore the critical-alarm threshold (_critalarm) as this information is not returned anymore.

Furthermore, this PR also introduces a output_scheme flag to allow to get the critical, high and actual temperatures as fields in one metric per sensor instead of one metric per sensor and type.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jun 14, 2022
@srebhan srebhan added area/system regression something that used to work, but is now broken labels Jun 14, 2022
plugins/inputs/temp/README.md Outdated Show resolved Hide resolved
plugins/inputs/temp/README.md Outdated Show resolved Hide resolved
plugins/inputs/temp/README.md Outdated Show resolved Hide resolved
plugins/inputs/temp/README.md Outdated Show resolved Hide resolved
plugins/inputs/temp/sample.conf Outdated Show resolved Hide resolved
@powersj
Copy link
Contributor

powersj commented Sep 21, 2022

@srebhan given the user reported the fields are still missing in #11294, and you filed the upstream issue, should this be closed for now?

@powersj powersj added the waiting for response waiting for response from contributor label Sep 21, 2022
@srebhan
Copy link
Member Author

srebhan commented Sep 26, 2022

Yeah seems like a good idea to close this PR. However, the upstream issue is sitting there for some time already...

@srebhan srebhan closed this Sep 26, 2022
@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/system fix pr to fix corresponding bug regression something that used to work, but is now broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undocumented regression in temp plugin
3 participants