-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Regression in temps introduced by gopsutil update #11301
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
added
area/system
regression
something that used to work, but is now broken
labels
Jun 14, 2022
Hipska
suggested changes
Jun 14, 2022
Hipska
reviewed
Jun 14, 2022
Co-authored-by: Thomas Casteleyn <[email protected]>
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Yeah seems like a good idea to close this PR. However, the upstream issue is sitting there for some time already... |
telegraf-tiger
bot
removed
the
waiting for response
waiting for response from contributor
label
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/system
fix
pr to fix corresponding bug
regression
something that used to work, but is now broken
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11294
This PR brings back critical (
_crit
) and high (_max
) temperature levels lost during a gopsutil update. We cannot restore the critical-alarm threshold (_critalarm
) as this information is not returned anymore.Furthermore, this PR also introduces a
output_scheme
flag to allow to get the critical, high and actual temperatures as fields in one metric per sensor instead of one metric per sensor and type.