Bug or a feature?

[s-r-engineer]

telegraf/plugins/inputs/kube_inventory/kube_state.go

Line 217 in 2372db9

SelectorExclude: []string{"*"},

Isn't it a bug to have "*" in that line? Because according to the function Match of IncludeExcludeFilter if you will have anything in "exclude" and anything in "include" then "exclude" will overwrite include. So by default you need to explicit an empty array in config for exclude to avoid that.

[srebhan]

Well the mentioned value matches the default documented in the sampleConfig field but does NOT match the text description above the option.

We have two options, either make the options match the text ("all included by default") by changing

SelectorExclude: []string{"*"},```
to
```golang
`SelectorExclude: []string{""},

OR to change the description that everything is _ex_cluded by default.

I think the first option makes more sense, but as this was already be published in releases ppl might rely on this...

@ssoroka, @sspaink, @reimda what do you think?

[sspaink]

Sorry for the late response, the first option does make more sense but it could break backward compatibility. Maybe for now we update the description, and we could update the option to match the text in 2.0?

We are tracking breaking changes here: #9478

[srebhan]

@sspaink I guess the question goes to @PPerminov!? :-)

[telegraf-tiger]

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you!