gatherCommandstatsLine

[lingfan]

Feature Request

Opening a feature request kicks off a discussion.

Proposal:

Current behavior:

Desired behavior:

func gatherCommandstatsLine(
	name string,
	line string,
	acc telegraf.Accumulator,
	global_tags map[string]string,
) {
	if strings.Contains(line, "calls=") {
		fields := make(map[string]interface{})
		tags := make(map[string]string)
		for k, v := range global_tags {
			tags[k] = v
		}
		tags["key_name"] = name
		dbparts := strings.Split(line, ",")
		for _, dbp := range dbparts {
			kv := strings.Split(dbp, "=")
			ival, err := strconv.ParseInt(kv[1], 10, 64)
			if err == nil {
				fields[kv[0]] = ival
			}
		}
		acc.AddFields("commandstats", fields, tags)
	}
}

Use case:

[danielnelson]

Link to upstream documentation: https://redis.io/commands/info

The commandstats section provides statistics based on the command type, including the number of calls, the total CPU time consumed by these commands, and the average CPU consumed per command execution.

For each command type, the following line is added:

• cmdstat_XXX: calls=XXX,usec=XXX,usec_per_call=XXX

The cluster section currently only contains a unique field:

• cluster_enabled: Indicate Redis cluster is enabled

The keyspace section provides statistics on the main dictionary of each database. The statistics are the number of keys, and the number of keys with an expiration.

For each database, the following line is added:

• dbXXX: keys=XXX,expires=XXX

[wingyplus]

I start prototyping gathering commandstats from info here.

Love to hear your feedback. :)

[glinton]

Awesome, feel free to open a pull request from your branch

[wingyplus]

@lingfan @glinton @danielnelson pull request opened. Suggestion are welcome. :)

[danielnelson]

Added in #5926