-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP Digest Access Authentication to the http input #4524
Comments
@spidie @marianob85 @aashley This issue replaces #461 |
Hello, I wonder if this feature request has any chance to be implemented. |
@yaazkal no this issue is still pending. Could you add your use case and why this addition would be helpful for you to help us prioritize against the other work in the project? Also, if someone from the community would like to take a stab at implementing this, we would be glad to review the PR. Thanks! |
@russorat Thanks for the answer. About Digest authentication (context)
Why is good to have it implemented My use case This is to use an API that a device called egauge has. The device dosen't support basic auth but digest authentication by default. As every device has it's own web server and I can't change its configuration (and If I can I will not want to because of the reference above), I'm forced to use Digest for every device, now as I'm using ansible to provision many raspberry pi and then every pi will consume an egauge device, this can solve my specific use case multiplied by the devices I'll provision :) Anyway I don't think there will be few use cases, as digest is a replacement of basic auth as cited before. |
Let me add that after writing this I've checked the code to see if I can open a PR. Found that golang has no digest auth support in the http module. As there are third party modules that add support for it, I'll sugest to discuss them first before choosing one or maybe do a feature request in golang. What do you think? Regards ! |
@yaazkal Doesn't appear that Go will be adding first party support for digest authentication in the near term. Would you be able to make a list of the libraries that implement support? |
@danielnelson I'm aware of the existence of: https://github.com/bobziuchkovski/digest wich is a fork of this I end up using the first of the list on a project because it was pretty straight forward but I had to change this switch because if the header also has I also tried with the other libraries but found them confusing and at the end they didn't worked for me (maybe is a lack of knowledge by my side). My general impression is that there is still work to be done in any of those and I'm not sure if they are maintained as I don't see recent activity (old commits, issues and PRs). PS if anyone end up searching for a workaraound to use digest in telegraf: For my project I end up using
|
My personal opinion is to contribute or request the digest support in golang directly and use the |
Maintained version of a library: https://github.com/icholy/digest |
Is this issue still relevant to anyone here? |
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you! |
Feature Request
Proposal:
The
http
input plugin should support HTTP Digest Authentication as desribed in rfc2617.There has been prior discussion of this feature on #461
Current behavior:
No support
Desired behavior:
Support added.
Example
Use case:
Needed for interop with servers expecting digest authentication
The text was updated successfully, but these errors were encountered: