Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "sum" to basicstats aggregator #3467

Closed
puckpuck opened this issue Nov 13, 2017 · 2 comments
Closed

Add "sum" to basicstats aggregator #3467

puckpuck opened this issue Nov 13, 2017 · 2 comments
Labels
feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@puckpuck
Copy link
Contributor

Feature Request

Proposal:

Add sum metric to basicstats.

Current behavior:

sum is not a computed aggregate.

Desired behavior:

sum would be part of computed aggregates in conjunction with count, min, etc.

Use case:

Although this can be computed (mean * count) it would be easier and consistent with many other metrics platforms if this was delivered out of the box. I would be happy to do this myself as a PR, but wanted to see if there was any reason why it wasn't done initially.

@danielnelson
Copy link
Contributor

I think it is probably something we can do, so long as we also do #3413. I imagine there will be interest in other simple aggregations.

@toni-moreno Do you have any thoughts on this?

@danielnelson danielnelson added the feature request Requests for new plugin and for new features to existing plugins label Nov 21, 2017
@danielnelson
Copy link
Contributor

Implemented in #3797 and will be in 1.6, thanks @cpacey

@danielnelson danielnelson added this to the 1.6.0 milestone Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

2 participants