Docker Plugin for Telegraf and Exclusive Parameters

[ono760]

Bug report

Telegraf plugin input docker says config can contain:

Containers to include and exclude. Collect all if empty. Globs accepted.

container_name_include = [] 
container_name_exclude = []

but inspection of this line here and testing shows that these are EXCLUSIVE parameters...

Expected behavior:

We would expect only "included*" containers that do not contain "test" to be published.

Actual behavior:

The following causes all but 'test' containers to be published:

container_name_include = [ "included*" ] 
container_name_exclude = ["*test*"]

Right now, whenever we do the above (specify BOTH include and exclude)
we get

included-something # should be here as expected - matches include ONLY 
somethingelse # should not be here - does not match include or exclude 
anotherthing # should not be here - does not match include or exclude 
include-somethingtest # should not be here - matches BOTH include AND exclude

but we don’t get

test-something-else-too # which matches exclude ONLY

We suspect the logic should be:

if len(d.ContainerInclude)>0 && ! d.ContainerFilter.containerInclude.Match(cname) { 
return nil 
} 
if len(d.ContainerExclude)>0 && d.ContainerFilter.containerExclude.Match(cname) { 
return nil 
}

System info:

Telegraf version: 1.4.1