Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics with trailing slash are not handled properly #3004

Closed
danielnelson opened this issue Jul 11, 2017 · 1 comment · Fixed by #3007
Closed

Metrics with trailing slash are not handled properly #3004

danielnelson opened this issue Jul 11, 2017 · 1 comment · Fixed by #3007
Labels
bug unexpected problem or unintended behavior panic issue that results in panics from Telegraf
Milestone

Comments

@danielnelson
Copy link
Contributor

Bug report

Line protocol does not allow escaping of backslashes and as a result any measurement name, tag key, tag value, field key, field value that ends with a backslash is invalid.

In 1.3.3, items ending with a backslash may be parsed incorrectly potentially resulting in panic or malformed metrics.

influxdata/influxdb#5231

Relevant telegraf.conf:

System info:

[Include Telegraf version, operating system name, and other relevant details]

Steps to reproduce:

  1. Create metrics with trailing slashes

Expected behavior:

Error? Removal of tailing slash?

Actual behavior:

Panic or malformed metric

Additional info:

[Include gist of relevant config, logs, etc.]

@danielnelson danielnelson added bug unexpected problem or unintended behavior panic issue that results in panics from Telegraf labels Jul 11, 2017
@danielnelson danielnelson added this to the 1.3.4 milestone Jul 11, 2017
@danielnelson
Copy link
Contributor Author

I am leaning towards automatic removal of trailing slash to avoid forcing all plugins to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior panic issue that results in panics from Telegraf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant