Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diskio: indicate device type #1428

Closed
phemmer opened this issue Jun 29, 2016 · 0 comments
Closed

Diskio: indicate device type #1428

phemmer opened this issue Jun 29, 2016 · 0 comments

Comments

@phemmer
Copy link
Contributor

phemmer commented Jun 29, 2016

Proposal:

When using the diskio plugin, provide a tag which indicates what the device type is. For example, LVM PV or VG, a partitioned disk, an md-raid member, a filesystem, etc.

Current behavior:

Right now, the only provided tag is name.

Desired behavior:

A tag which indicates what the device type is. For example, LVM PV or VG, a partitioned disk, an md-raid member, a filesystem, etc.

Use case: [Why is this important (helps with prioritizing requests)]

For devices which have been sliced up (LVM PV or VG, partitioned disk, etc), the diskio plugin is going to report on both the parent device, as well as the child devices. For example, on a partitioned disk named sda, it's going to report on sda, sda1, and sda2. The metrics for sda are (mostly) just going to be the summation of the sda1 and sda2 metrics. Therefore, it would be useful to be able to filter out the parent devices when performing queries against influxdb.
Or, if you are interested in the parent devices, you could use the feature to filter out the children.

@phemmer phemmer changed the title Diskio: indicate when a device type Diskio: indicate device type Jun 29, 2016
@sparrc sparrc closed this as completed in 074e6d1 Jan 28, 2017
njwhite pushed a commit to njwhite/telegraf that referenced this issue Jan 31, 2017
mlindes pushed a commit to Comcast/telegraf that referenced this issue Feb 6, 2017
maxunt pushed a commit that referenced this issue Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant