-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telegraf crashing in 1.26 version #13219
Comments
Hi,
Can you please update to v1.26.2, reproduce, and provide the full trace please. Are you building a custom version of telegraf? Are you applying any patch to the prometheus plugin itself? |
We are building custom version with telegraf.star and telegraf_processor.star. No we are not applying patch to prometeus plugin.
|
@redbaron based on the above crash it looks like we may need to add some mutex around access to the pods. Does it make sense to do this in the |
@samskan , your sample config shows |
@redbaron we do have multiple prometheus plugins. But I am sure that only the above mentioned plugin is causing the issue. When we comment this input plugin we dont see the crash.
|
@samskan , thanks. I suspect adding extra plugin instance just highlights existing race. I prepared PR which streamlines Prometheus plugin initialization, which might or might not help with your case: #13231 . If you don't mind building it with |
@redbaron I think previously i mentioned that we are building custom version of telegraf. But we are not. We are just taking the released version and using our own telegraf.star and telegraf_processor.star. |
@powersj , is it possible to add docker image to the artifact list built for each PR? |
Unfortunately, this is not something we plan on doing. The amount of artifacts generated are already fairly costly. |
With the provided artifacts, there was no panic observed.Please let me know when we can get this in the official release |
Thank you for confirming. It will go into v1.26.3 in a couple weeks. |
correct, if you want to try this out please use a nightly build: https://github.com/influxdata/telegraf/blob/master/docs/NIGHTLIES.md |
When can I expect this fix to be present in the official build? |
@powersj Please let me know when this fix will be part of official build? |
You can look at the very first question in the FAQ: https://github.com/influxdata/telegraf/blob/master/docs/FAQ.md As June is in 2 days it will be part of the next minor release, v1.27 |
Relevant telegraf.conf
Logs from Telegraf
System info
TelegrafVersion:1.26, OS:Mariner,2.0.20230407
Docker
No response
Steps to reproduce
2.add the input kubernetes-service for cadvisor
...
Expected behavior
Telegraf should not panic. It should be up and running
Actual behavior
Telegraf is crashing
Additional info
No response
The text was updated successfully, but these errors were encountered: