-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented regression in temp
plugin
#11294
Comments
@quentinmit can you please test the artifacts built in #11301 once it is finished!? I currently see no (non-manual) way to get back |
It's not just Probably this needs to be fixed upstream in |
Testing the artifacts from #11301 on one of my machines, I get:
As expected, You're reporting new Also, it looks like the naming is subtly different ( And finally, this is specific to Linux... I don't have a Windows machine handy but I would imagine their sensors don't follow this naming convention, so make sure you're not introducing a new regression on non-Linux platforms. |
@quentinmit yeah I tried to work around the change in |
Yeah, I'd say figure out how to avoid reporting 0 when the limits don't exist, and otherwise that's the best you can do given the current gopsutil API. But maybe you can chase down an upstream bug to get them to fix/revert their API. |
@quentinmit reported the issue upstream in shirou/gopsutil#1319. |
Attempted fix in shirou/gopsutil#1546. |
@quentinmit sorry for coming back so late to this issue. Can you please test the binary in PR #14575 once CI finished the tests!? With |
Relevant telegraf.conf
Logs from Telegraf
System info
Telegraf 1.22.4 on Debian 11
Docker
No response
Steps to reproduce
temp
input on a Linux system that hashwmon
devices.Expected behavior
In older versions (at least Telegraf <=1.17.3 but I haven't exhaustively tested), each temperature from
/sys/class/hwmon/*/temp_*
is exposed as a stream with asensor
tag derived from the filename in/sys
:This is also what is documented in the
temp
plugin's README.Actual behavior
In new builds (at least Telegraf >=1.22.4, sorry I have't bisected) only the
/sys/class/hwmon/*/temp_*_input
temperatures are exposed:which means that the max/crit/etc. values are no longer being reported anywhere, nor are any sensors that don't follow the pattern of
temp_*_input
. It looks like this was broken when you pulled in shirou/gopsutil#905I'm not sure what you should do to fix this now, but metrics shouldn't have undocumented regressions in their structure like this between versions. Ideally you would revert back to the old behavior because there is now missing data, in addition to the schema change. It looks like
gopsutil
now exposes the max and crit levels as fields that you could turn into metrics, but the other values are just dropped bygopsutil
.Additional info
No response
The text was updated successfully, but these errors were encountered: