Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update replace dependencies #11164

Closed
4 tasks done
powersj opened this issue May 23, 2022 · 2 comments · Fixed by #11236 or #11401
Closed
4 tasks done

go.mod: update replace dependencies #11164

powersj opened this issue May 23, 2022 · 2 comments · Fixed by #11236 or #11401
Assignees
Labels
help wanted Request for community participation, code, contribution size/m 2-4 day effort

Comments

@powersj
Copy link
Contributor

powersj commented May 23, 2022

Feature Request

Opening a feature request kicks off a discussion.

Proposal:

There are currently four replace stanzas in our go.mod. Looking at the bugs that were opened for each of these, at least the last 3 appear to be closed and resolved.

If updating or removing the replace stanzas is not possible, then add a reason as to why. Investigate the following:

The third one appears to be a PR against a fork. The fork itself has the protobuf files now. The second and fourth appear to be resolved and in master. The first may require additional investigation.

@powersj powersj added the feature request Requests for new plugin and for new features to existing plugins label May 23, 2022
@powersj powersj removed feature request Requests for new plugin and for new features to existing plugins area/cisco labels May 23, 2022
@sspaink sspaink added the help wanted Request for community participation, code, contribution label May 24, 2022
@sspaink
Copy link
Contributor

sspaink commented May 24, 2022

next steps: review the checklist

@reimda
Copy link
Contributor

reimda commented Jun 27, 2022

If the nx-telemetry-proto replacement is still needed, let's add a comment with a date in the go.mod so we know in the future when to check again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Request for community participation, code, contribution size/m 2-4 day effort
Projects
None yet
5 participants