Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Extract Connection Limiting Logic out Of S3 #16

Closed
tustvold opened this issue May 23, 2022 · 1 comment
Closed

Extract Connection Limiting Logic out Of S3 #16

tustvold opened this issue May 23, 2022 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tustvold
Copy link
Contributor

Problem

The S3 implementation currently has a SemaphoreClient that limits concurrent requests, this is useful beyond just S3, confuses the implementation, and dates from a time when ObjectStore was not object-safe.

Proposal

I would like a LimitStore that wraps a <T: ObjectStore> much like ThrottledStore and provides a configurable concurrency limit.
@tustvold tustvold added good first issue Good for newcomers help wanted Extra attention is needed labels May 23, 2022
@tustvold tustvold mentioned this issue Jun 27, 2022
Merged
@alamb alamb mentioned this issue Jul 26, 2022
Closed
@alamb
Copy link
Contributor

alamb commented Jul 26, 2022

Ported to arrow apache/arrow-rs#2175

@alamb alamb closed this as completed Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @tustvold