Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to influxd upgrade command #19985

Closed
2 tasks done
stuartcarnie opened this issue Nov 11, 2020 · 2 comments
Closed
2 tasks done

Improvements to influxd upgrade command #19985

stuartcarnie opened this issue Nov 11, 2020 · 2 comments
Assignees
Labels
area/2.x OSS 2.0 related issues and PRs

Comments

@stuartcarnie
Copy link
Contributor

stuartcarnie commented Nov 11, 2020

What

In order to improve the upgrade experience for users moving from 1.x to 2.x, the following improvements should be added to the influxd upgrade command:

  • If the meta.db contains existing continuous queries, these should be written out to a separate file, continuous_queries.txt. This path should be available as a flag that can be changed, with a default value along side the upgrade.log

  • If the influxdb 1.x configuration file has disabled HTTP authentication and has users, this should be logged as a warning.

    # Determines whether HTTP authentication is enabled.
    # auth-enabled = false
    

Disabled HTTP authentication

If this feature is disabled in InfluxDB 1.x, clients sending requests with credentials are ignored by influxd. This may result in failures after upgrading for the following reasons:

  • If the 1.x instance has users and 1.x clients, such as telegraf, are sending credentials, they will be silently ignored by InfluxDB 1.x
  • Once upgraded to 2.x, those clients' requests will now be authorised by influxd 2.x and fail with a 401 Unauthorized response if the credentials do not match.

NOTE: We may wish to alter the upgrade process in future, such that if HTTP auth is disabled, the users are not copied to 2.x.

@stuartcarnie stuartcarnie added the area/2.x OSS 2.0 related issues and PRs label Nov 11, 2020
@danxmoran danxmoran self-assigned this Nov 12, 2020
@danxmoran
Copy link
Contributor

danxmoran commented Nov 12, 2020

I would also like to add:

  • Move as many input validations as possible to the beginning of execution (i.e. input paths pointing to nonexistent files, output paths pointing to existing files)

@danxmoran
Copy link
Contributor

Closed in #20012 #20036 #20039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/2.x OSS 2.0 related issues and PRs
Projects
None yet
Development

No branches or pull requests

2 participants