Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use v.windowPeriod in the derivative unit param #19256

Closed
russorat opened this issue Aug 7, 2020 · 2 comments · Fixed by influxdata/ui#186
Closed

do not use v.windowPeriod in the derivative unit param #19256

russorat opened this issue Aug 7, 2020 · 2 comments · Fixed by influxdata/ui#186

Comments

@russorat
Copy link
Contributor

russorat commented Aug 7, 2020

right now, clicking on derivative or non negative derivative in the UI inserts

 |> derivative(unit: v.windowPeriod, nonNegative: false)

but the unit isn't a window period.

most likely, they want something like this:

  |> aggregateWindow(every: v.windowPeriod, fn: max)
  |> derivative(unit: 1s, nonNegative: false)

We may need to update the label in the UI but i'm not sure.

Acceptance Criteria

  • Hard code derivative to 1 second in the UI. And also the nonNegative derivative as well.
@kristinarobinson
Copy link

Hard code derivative to 1 second in the UI. And also the nonNegative derivative as well.

@russorat
Copy link
Contributor Author

fixed in #19776, but it needs to get added to the UI repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants