Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache queries made in dashboard and VEO #18791

Closed
10 of 12 tasks
ebb-tide opened this issue Jun 29, 2020 · 3 comments · Fixed by #19010 or #19072
Closed
10 of 12 tasks

Cache queries made in dashboard and VEO #18791

ebb-tide opened this issue Jun 29, 2020 · 3 comments · Fixed by #19010 or #19072

Comments

@ebb-tide
Copy link
Contributor

ebb-tide commented Jun 29, 2020

writing to the cache

  • On dashboard page, when query is issued for cell, query results should be cached in redux store. cache is keyed by externs and query text.
  • On dashboard page, when VEO is visible, when query is issued in VEO, query results should be cached in redux store. queries cached in VEO should 'expire' after a few minutes.

invalidating cache:

  • When user navigates away from a dashboard, the query cache should be invalidated/cleared so that when user navigates to the same dashboard again, cells are re-queried.
  • When a dashboard loads for the first time, all queries must query the database directly and not the cache
  • On dashboard Page, when viewing cells, the reload button should invalidate the cache and re-query for all cells.
  • In Autoreload(OSS)
  • When user clicks submit.

reading from cache:

  • On dashboard page, when user clicks on configure to edit cell query, the VEO should load and display query results from the cache. (this is already done)
  • On dashboard page, when user clicks 'cancel' on VEO, background dashboard cells should attempt to query, but results should resolve from the cache, user should see dashboard as it was before they launched VEO even if they had selected a different time range or variable value in the VEO.
  • On dashboard page, when user clicks 'save' on VEO without having ever submitting the query in the VEO (by clicking submit or changing variable value/time range), background dashboard cells should attempt to query, but results should resolve from the cache, user should see dashboard as it was before they launched VEO.
  • On dashboard page, when VEO is visible, background dashboard cells should not attempt to query, even when time windows/variable values change. (in PR)
  • On dashboard page, when user clicks 'save' on VEO, if user had resubmitted query in VEO, either by clicking submit, or changing query/variables/timeRange- all cells on dashboard should re-query. The edited cell should receive results from cache if it has not expired.
@ebb-tide ebb-tide changed the title Create query cache for queries made in dashboard and VEO. (WIP) Create query cache for queries made in dashboard and VEO Jun 29, 2020
@ebb-tide ebb-tide changed the title Create query cache for queries made in dashboard and VEO Cache queries made in dashboard and VEO Jul 12, 2020
@asalem1
Copy link
Contributor

asalem1 commented Jul 20, 2020

[x] Need to reset query's based on IDs when a query is submitted in the VEO & set the queryCache
[x] Need to invalidate the cached data after 5s

@russorat
Copy link
Contributor

Need to invalidate the cached data after 5s

this should be easy to change.

@asalem1
Copy link
Contributor

asalem1 commented Jul 21, 2020

Need to invalidate the cached data after 5s

this should be easy to change.

Famous last words 😃

Those were just mental notes that are already addressed in the PR linked to this:

#19010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment