Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload query when opening a cell #18401

Closed
russorat opened this issue Jun 8, 2020 · 2 comments · Fixed by #18581
Closed

Don't reload query when opening a cell #18401

russorat opened this issue Jun 8, 2020 · 2 comments · Fixed by #18581

Comments

@russorat
Copy link
Contributor

russorat commented Jun 8, 2020

We should not refresh the query when opening a cell. We already have the results so we should just display them and not re-run the query or any dependent queries.

@ebb-tide
Copy link
Contributor

ebb-tide commented Jun 16, 2020

@russorat one concern with the behavior this issue implies-
Let's say we query the dashboard at time t for the past five minutes. and wait one minute before clicking 'configure cell'.
The time dropdown in VEO will say "past five minutes" but will actually be displaying data between t-5 and t.
Is this what you would expect?
At which point would we refetch the data if it is too stale?

@russorat
Copy link
Contributor Author

The x-axis will still display the correct time range. the user will know better than we will what "stale" is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants