Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please reconsider forking httprouter #16695

Open
eclipseo opened this issue Feb 1, 2020 · 2 comments
Open

Please reconsider forking httprouter #16695

eclipseo opened this issue Feb 1, 2020 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@eclipseo
Copy link
Contributor

eclipseo commented Feb 1, 2020

Back in 3dbb9c0 you decided to fork julienschmidt/httprouter to influxdata/httprouter . I'd like you to reconsider forking project like this and move your changes upstream as much as possible. This fork will likely not be taken care off and will be cut from upstream updates and potential security fixes.

You already have forked this project before and it was never updated anymore: github.com/bouk/httprouter

So now you have 2 forks of the same project to add a single feature, which will never benefit from upstream updates.

@russorat
Copy link
Contributor

@eclipseo thanks for the issue. @GeorgeMac what do you think? Was there a specific reason for the fork?

@russorat russorat added the dependencies Pull requests that update a dependency file label Feb 12, 2020
@GeorgeMac
Copy link
Contributor

Thanks @eclipseo and @russorat !
I will get this on my radar as support for what we needed got merged into julienschmidt/httprouter#286
It is slightly different shape to our fork, but solves the same problem. So I just need to do a bit of work to get the upstream change integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants