Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor updateCheck implementation to consolidate like functions #16339

Open
asalem1 opened this issue Dec 27, 2019 · 1 comment
Open

Refactor updateCheck implementation to consolidate like functions #16339

asalem1 opened this issue Dec 27, 2019 · 1 comment

Comments

@asalem1
Copy link
Contributor

asalem1 commented Dec 27, 2019

Problem

updateCheck was removed in the following PR:

#16333

in order to refactor the way the functionality was implemented. However, the linter never returned an error that the updateCheck was still in use here:

https://github.com/influxdata/influxdb/blob/master/ui/src/alerting/components/CheckCard.tsx#L17

As a result, the function was readded to the actions.

The problem we need to resolve is to update the functionality of the existing functions to make updateCheck redundant.

@asalem1
Copy link
Contributor Author

asalem1 commented Dec 27, 2019

@ebb-tide do you think this encompasses the issue? Would you like to add anything to this? Perhaps some context on why we initially removed the updateCheck and what might be needed going forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant