Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling #14609

Open
desa opened this issue Aug 9, 2019 · 2 comments
Open

Better error handling #14609

desa opened this issue Aug 9, 2019 · 2 comments
Labels

Comments

@desa
Copy link
Contributor

desa commented Aug 9, 2019

There are a number of places where we do not display the error we get back from the API. This can be confusing to end users. It would be great to have a wholistic approach to how we handle errors in the front-end.

@desa desa added this to the Sprint 6 - Fluorite milestone Aug 9, 2019
@desa desa added the team/ui label Aug 9, 2019
@chnn
Copy link
Contributor

chnn commented Aug 12, 2019

Random thoughts:

  • I think the most positive change we can make in the UI is to specify error states in mockups to begin with. We almost never do, and I think the result is engineers not thinking about the error path much (or if they do, it's just to display a notification, which is a bit lazy)

  • I've noticed some areas where the API could be more consistent. For example, writing a syntactically invalid Flux query returns a 500 error when a 400 or 422 is likely more appropriate. It also returns the useful error message in the error field on the JSON response, rather than the message field like most other endpoints

  • Move API client generation into influxdb #14482 should help us know about what errors we should be handling while in development

@stale
Copy link

stale bot commented Nov 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 24, 2019
@stale stale bot removed the wontfix label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants