Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Alter existing users #107

Closed
ChristopherRabotin opened this issue Feb 21, 2015 · 5 comments
Closed

Alter existing users #107

ChristopherRabotin opened this issue Feb 21, 2015 · 5 comments

Comments

@ChristopherRabotin
Copy link
Contributor

There's currently a TODO on it, so I'll just handle that. ;)

@ChristopherRabotin
Copy link
Contributor Author

@ReAzem , if you're happy with this commit I'll start writing tests. I think that merging in update_database_user_password with update_database_user_permissions (which currently raises NotImplementedError) makes it more similar to alter_database_admin and keeps everything in one function. Let me know.

@aviau
Copy link
Collaborator

aviau commented Feb 22, 2015

@ChristopherRabotin This makes perfect sense. I will gladly review/merge this PR.

On another note, I would suggest you take a look at InfluxDB 0.9.0 since the way of altering users will be different. I have started adapting the lib to 0.9.0 on the 0.9.0_support branch. Maybe you would like to work on this feature for 0.9.0 too?

@ChristopherRabotin
Copy link
Contributor Author

Cool, I'll get the tests done this week then.

Sure, I can handle that for 0.9.0 as well. I'll focus on 0.8 first though because that's the version we use at work.

@ChristopherRabotin
Copy link
Contributor Author

Should this issue be closed since user alteration for 0.9 is in #109 ?

@aviau
Copy link
Collaborator

aviau commented Apr 2, 2015

Yep!

@aviau aviau closed this as completed Apr 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants