-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: cdk generate project template should refer to fluvio stable release #3785
Comments
An additional related item to decouple the connector dep references is that fluvio-connector-common also referenced, is not a released crate, so it can't be referenced via crates.io |
fwiw
That way can ensure the compatibility across types etc. |
We definitely have a set of options with different tradeoffs to consider. Export as a feature adds adds bulk to the fluvio crate, but is nice that it keeps everything in sync for the end dep user. |
Stale issue message |
fyi Would be perhaps good to test with a dummy connector that release ref from git works upon stable release. |
What happened
cdk generate generates a project where the Cargo.toml contains fluvio (and fluvio related crate) dependency of:
Expected behavior
The generated project should create
How to reproduce it (as minimally and precisely as possible)
Steps to reproduce the behavior:
cdk generate <projectname>
cat projectname/Cargo.toml
Environment (please complete the following information):
cdk
Additional context
The immediate fix could be to change the template to refer to a stable fluvio.
The Cargo.lock would maintain the specific patch version.
The text was updated successfully, but these errors were encountered: