Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small manual verifications :
regressionCheck.ts
still runs fine and is representative of the NPM use caseexpress
(popular framework) andsharp
(different image file formats)Overall the code was already fine, I just added information and helper functions in
README.md
since converting to Tensor3d and convert file formats can be hard for someone unfamiliar.I only wasn't able to
nsfw.load(...)
the TensorflowJS 299x299 Image Model files, they seem different from what is loaded by default TensorflowJS Quantized 224x224 Image Model.Since it is interesting to load bigger models in server side comparing to client side, you might also want to provide information on how to load the three other bigger models at:
https://github.com/GantMan/nsfw_model
Ideally these 4 should be tested with Jest too, I don't know if you plan to maintain them or update them depending on how the scrapper repo updates.