Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] v10 - Refactor Toggle #2644

Closed
frankcalise opened this issue Feb 20, 2024 · 4 comments · Fixed by #2667
Closed

[Enhancement] v10 - Refactor Toggle #2644

frankcalise opened this issue Feb 20, 2024 · 4 comments · Fixed by #2667
Assignees
Milestone

Comments

@frankcalise
Copy link
Contributor

Overview

  • Toggle.tsx component is large, houses 3 components and is hard to read
  • Refactor into Checkbox/Switch/Radio components
  • Possibly refactor reanimated code related to RTL Switch
  • Target branch v10
@markrickert
Copy link
Member

Awesome! This definitely should be done. I think removing reanimated as a direct dependency of any of our components is a good idea. We can keep it in the package json because it's required for other things, but I don't think we should be using reanimated in our default components.

@frankcalise
Copy link
Contributor Author

@markrickert so you're saying the components dir to only rely on Animated from core RN?

@markrickert
Copy link
Member

Yeah, i think our boilerplate components should be as simple as possible. I don't think ignite should be in the business of advanced animation examples unless we're actually using that animation and component in a real project. My opinion is the simpler the better. Take with a grain of 🧂 😄

@frankcalise
Copy link
Contributor Author

Closed by #2667 in v10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants