[WIP] more types #800
Closed
[WIP] more types #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeSheard
reviewed
Feb 4, 2017
| @@ -44,6 +44,14 @@ export interface ComponentLifecycle<P, S> { | |||
| componentWillUnmount?: () => void; | |||
| } | |||
|
|
|||
| export type SFC<P> = StatelessComponent<P>; | |||
There was a problem hiding this comment.
While it's more verbose. In terms of DX I think that only using StatelessComponent<P> would be better. I think it will avoid a lot of questions with "What's SFC mean?" for new contributors.
There was a problem hiding this comment.
yeah either way is fine for me. SFC has been in React for a while
Havunen
reviewed
Feb 8, 2017
packages/inferno/src/interface.ts
Outdated
| textPath: SVGProps; | ||
| tspan: SVGProps; | ||
| use: SVGProps; | ||
| view: SVGProps; |
There was a problem hiding this comment.
what about xlink:href: SVGProps; ?
|
@Havunen this is pretty far from ready :( I'm still workin on it. I'll take the WIP tag away once it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR please:
npm run buildand check that the build succeeds.PR Template
Objective
Adds more types, fixes #798