Add module field in package.json

[Ashot-KR]

Since v1.3.0 inferno and it's packages has dist-es folder, so why don't add a module field to import bundled Inferno es2015 module with import Inferno from 'inferno'? At this moment i should use import Inferno from 'inferno/dist-es'.

By the way: most installed inferno packages has node_modules folder with inferno-shared in it. What's the point of this? why it not installed as dependency to projects node_modules folder? Now i have installed inferno and 4 inferno packages and each has it's own inferno-shared, it looks strange to me.

And thanks for your work, Inferno is great.

[Havunen]

Because many users started reporting errors when they used ES6 modules. So I simply dropped the module field. You can use it at your own risk, we don't currently support it because module entry point is undocumented feature.

[Ashot-KR]

I've made experiment:

1. i added "module": "dist-es/index.js" to installed inferno and it's packages manually
2. tried to bundle project and get error warning' is not exported by node_modules/inferno/node_modules/inferno-shared/dist/inferno-shared.node.js because each package has it's own inferno-shared module and inferno-shared.node.js do not export warning as it cjs module
3. i removed node_modules from all packages, installed inferno-shared to project and added "module": "dist-es/index.js" to it package.json
   and my project bundled successfully (except some warning during bundle process). I used rollup bundler.

Anyway i can't claim that Inferno really need in module(or jsnext:main) field. Thanks for your answer!

[Havunen]

Btw 'inferno:main' is pointing to es6

[TrySound]

@Havunen I'm maintainer of rollup-plugin-node-resolve. If there's a problem, let's fix it. Bundling commonjs is not efficient for libraries. As you can see redux uses this too reduce bundle size.
reduxjs/redux#2283

[longlho]

@TrySound problem is that people don't configure rollup/webpack to transpile ES6 in node_modules. Webpack also has a different mechanism of wrapping default-exported module that uses defineProperty, making getter/setter injection broken. Not to mention TS ecosystem as well:

See:
#903
#686

It's more than just the rollup ecosystem

[teehemkay]

@Ashot-KR @Havunen

FWIW, I've noticed that code in inferno/dist-es/**/*.js imports from inferno-shared.
But shouldn't they instead import from inferno-shared/dist-es?

[LukeSheard]

@teehemkay If you're resolving inferno:main as your entry point in something like web pack then inferno-shared will refer to inferno-shared/dist-es. Since we now support the inferno:main tag for ES6 I'm going to close this. If people still have strong opinion about this feel free to reopen.