forwardRef fails on patchFunctionalComponent

[ChrisKuBa]

Hi,

when patching a function component inferno dosn't differ between function component with and without forwardrefs, like on mounting.

function mountFunctionalComponent$2(vNode, parentDOM, context, isSVG, nextNode, lifecycle) {
  ...
  var ref = vNode.ref;
  var input = handleComponentInput$2(vNode.flags & 32768
  /* ForwardRef */
  ? type(props, ref, context) : type(props, context));
 ...
}

function patchFunctionalComponent(lastVNode, nextVNode, parentDOM, context, isSVG, nextNode, lifecycle) {
  ...
  if (shouldUpdate !== false) {
    if (nextHooksDefined && isFunction(nextRef.onComponentWillUpdate)) {
      nextRef.onComponentWillUpdate(lastProps, nextProps);
    }

    var nextInput = handleComponentInput(nextVNode.type(nextProps, context));
    patch(lastInput, nextInput, parentDOM, context, isSVG, nextNode, lifecycle);
  ...
}

So the call to nextVNode.type will be without ref. At the end ref is context, lastVNode.ref !== nextVNode.ref and the ref will be nulled.

   ...
  var nextRef = nextVNode.ref;
  var lastRef = lastVNode.ref;

  if (lastRef !== nextRef) {
    unmountRef$2(lastRef);
    mountRef$2(nextRef, dom, lifecycle);
  }
   ...

Thx

[Havunen]

Hi @chrkulbe

Thanks for reporting this issue, I will have a look into it when I have some free time :)

[Havunen]

Fixed in master