Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot find module 'inferno-shared'" after 3.10.1 -> 4.0.4 upgrade #1284

Closed
jasontbradshaw opened this issue Feb 22, 2018 · 1 comment
Closed
Labels

Comments

@jasontbradshaw
Copy link

jasontbradshaw commented Feb 22, 2018

Issue Template

Observed Behaviour
When upgrading from inferno 3.10.1 to 4.0.4 in a TypeScript/webpack/awesome-typescript-loader project, the included index.d.ts file declares a dependency on inferno-shared that can't be resolved at compile time, resulting in the following error:

ERROR in [at-loader] ./node_modules/inferno/dist/index.d.ts:8:27 
    TS2307: Cannot find module 'inferno-shared'.

This comes from index.d.ts:8 in the inferno package:

import { NO_OP } from 'inferno-shared';

Expected Current Behaviour
This shouldn't happen.

Inferno Metadata
Linux/Firefox

Workaround
Including inferno-shared 4.0.4 as a devDependency fixes the issue, so I suspect that the problem isn't much deeper than a forgotten dependency declaration somewhere.

@Havunen Havunen added the bug label Feb 27, 2018
@Havunen
Copy link
Member

Havunen commented Feb 27, 2018

Thanks for reporting the issue! This should be fixed in 4.0.6

@Havunen Havunen closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants