Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support camera ray collision for indented cubes #406

Open
westernheld opened this issue Jun 19, 2021 · 1 comment · May be fixed by #423
Open

Support camera ray collision for indented cubes #406

westernheld opened this issue Jun 19, 2021 · 1 comment · May be fixed by #423
Assignees
Labels
cat:enhancement enhancement/requested feature/update of existing features diff:expert expert skills required feat:octree octree, cube computations prio:blocker this issue cannot be moved to a later milestone, also this label cannot be removed

Comments

@westernheld
Copy link
Member

Describe the bug
The collison detection is just working if the camera ray hits a solid cube. Fragmented cubes will be ignored. This will have different impacts depending on the situation:

  1. Just one fragment before the void: No collision at all
  2. A fragment in front of a full cube: The collision will detect the full cube, not the fragment in front of it.

To Reproduce
Steps to reproduce the behavior:
Go to a fragmented cube and see the console log.

Expected behavior
Make collision work with all possible conditions of a cube. Solid and fragmented.

Screenshots
No collision at fragment in lower left corner
image
Collision with a solid cube slightly above the fragment
image

Inexor Version: b0b2c46

@westernheld westernheld added cat:bug bug/error/mistake which limits the program feat:octree octree, cube computations labels Jun 19, 2021
@IceflowRE IceflowRE added cat:enhancement enhancement/requested feature/update of existing features prio:blocker this issue cannot be moved to a later milestone, also this label cannot be removed and removed cat:bug bug/error/mistake which limits the program labels Jun 22, 2021
@IceflowRE
Copy link
Member

Removed cat:bug as this was an intentional decision. Nonless it should also work with indented cubes.

@IceflowRE IceflowRE changed the title Collision just working for solid cubes Support camera ray collision for indented cubes Jun 22, 2021
@IceflowRE IceflowRE added the diff:expert expert skills required label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement enhancement/requested feature/update of existing features diff:expert expert skills required feat:octree octree, cube computations prio:blocker this issue cannot be moved to a later milestone, also this label cannot be removed
Projects
None yet
3 participants