Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept None value in ZstdCompressor/ZstdDecompressor constructors parameters #153

Closed
wants to merge 2 commits into from
Closed

Accept None value in ZstdCompressor/ZstdDecompressor constructors parameters #153

wants to merge 2 commits into from

Conversation

rodrigozhou
Copy link
Contributor

Change constructors of ZstdCompressor and ZstdDecompressor to accept explicit None value for optional parameters (eg: dict_data). Also changing stubs to reflect this.

@rodrigozhou rodrigozhou mentioned this pull request Jun 2, 2021
Closed
indygreg
indygreg requested changes Jul 5, 2021
View reviewed changes
Copy link
Owner

@indygreg indygreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch seems reasonable to me and fixes an unwanted divergence in behavior between the C and CFFI backends.

Could you please add a test that verifies that None arguments work? This will help ensure the different backends have consistent behavior.

@rodrigozhou rodrigozhou requested a review from indygreg July 19, 2021 22:39
indygreg
indygreg approved these changes Oct 16, 2021
View reviewed changes
Copy link
Owner

@indygreg indygreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

I'm going to tweak the commits up slightly as part of rebasing. But I will preserve your author annotation so you get credit for the change.

Thank you for this contribution!

@indygreg indygreg closed this in f0c6f93 Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indygreg indygreg indygreg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigozhou @indygreg