-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type stubs #17
Add type stubs #17
Conversation
Also, would it be possible to create a new release with my recent changes? 🙏 |
Is there a way to automate the generation, or at least have a CI job that checks that they're up to date? |
(And sure, I'd be happy to roll a release once we're done here.) |
There seems to be a library to automatically generate those, but with limitations. I'm not familiar enough with Rust/Maturin to know how to wire it. The following command can be used to validate the stubs:
I need to wire it into the workflow. |
I added a validation step. It's inside the "pytest" job, because I need the built module to be able to test stubs, and preferred not to create yet another job building the wheels. Note: The |
Thanks for adding the validation step. Upon playing around with it a bit, I noticed that passing |
I added another way to handle this via an allowlist. It specifies a list of modules where to ignore errors. It should ignore errors related to |
Thanks! That seems to do the trick. |
A new release is on the way. |
Those stubs are generated from the generated API documentation, with fixes provided in #15 and #16.