Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully correct flow submissions get truncated as 99.99% #731

Open
nicknytko opened this issue Sep 2, 2020 · 4 comments
Open

Fully correct flow submissions get truncated as 99.99% #731

nicknytko opened this issue Sep 2, 2020 · 4 comments

Comments

@nicknytko
Copy link

image

When getting full points on a flow, the results page will show a 99.99% instead of 100.00%. This is at the url:

https://relate.cs.illinois.edu/course/[course]/flow-session/[flow-id]/finish/

@inducer
Copy link
Owner

inducer commented Sep 2, 2020

Thanks for the report! Does this happen always, or just under specific circumstances? (I've never observed it myself, so I'd be surprised if the answer was 'always'.) If it's "only sometimes", would you mind sending me (by private email) an example flow ID on the Illinois instance so I have a reproducer to look at?

@nicknytko
Copy link
Author

I think this always happens, but I can send an example flow id if that would be helpful

@inducer
Copy link
Owner

inducer commented Sep 2, 2021

#758 contains work towards this.

@inducer
Copy link
Owner

inducer commented Sep 2, 2021

The issue is that the percent bar breaks if it gets bar lengths that add up to 100%. That’s why there’s logic to limit the sum of the bars lengths to 99.99%. And somehow that number has found its way into another part of the presentation code for the flow result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants