From f2245c4bbc0e3ed25ac68f9993627bc334d01eb3 Mon Sep 17 00:00:00 2001 From: TeddTech Date: Mon, 20 Jul 2020 16:26:13 -0700 Subject: [PATCH 1/5] fix: applied inline flex to tag fiter label span --- src/scss/components/_filter.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/scss/components/_filter.scss b/src/scss/components/_filter.scss index c74702006..041428262 100644 --- a/src/scss/components/_filter.scss +++ b/src/scss/components/_filter.scss @@ -133,6 +133,10 @@ .apply-button, .reset-button { + span { + display: inline-flex; + } + &:focus, &:hover { svg { From bdf6abcf077c4a63845316bc4140b638d00656ec Mon Sep 17 00:00:00 2001 From: TeddTech Date: Tue, 8 Sep 2020 15:33:36 -0700 Subject: [PATCH 2/5] fix: added pagination styling for galazy screen --- src/scss/components/_pagination.scss | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/scss/components/_pagination.scss b/src/scss/components/_pagination.scss index e53dfdd44..ae888c0df 100644 --- a/src/scss/components/_pagination.scss +++ b/src/scss/components/_pagination.scss @@ -2,6 +2,8 @@ display: block; line-height: rem(32); list-style: none; + margin-left: -10%; + margin-right: -10%; margin-top: rem(27); padding: 0; text-align: center; @@ -157,3 +159,20 @@ } } } + +// This media query breakpoint comes the width of the Galaxy Fold screen. +@include breakpoint-down(xs) { + .pagination { + .pagination-link { + font-size: rem(18); + height: rem(42); + line-height: rem(43); + margin: rem(10) rem(3); + width: rem(42); + } + + .pagination-ellipsis span { + font-size: rem(18); + } + } +} From d85ae8b62faae20502342b225444eb50cb2d53f9 Mon Sep 17 00:00:00 2001 From: TeddTech Date: Tue, 8 Sep 2020 16:44:03 -0700 Subject: [PATCH 3/5] fix: decreased pagination font size in mobile view --- src/scss/components/_pagination.scss | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/scss/components/_pagination.scss b/src/scss/components/_pagination.scss index ae888c0df..383942cc1 100644 --- a/src/scss/components/_pagination.scss +++ b/src/scss/components/_pagination.scss @@ -1,6 +1,6 @@ .pagination { display: block; - line-height: rem(32); + line-height: rem(38); list-style: none; margin-left: -10%; margin-right: -10%; @@ -32,7 +32,7 @@ border-radius: 100%; box-shadow: 0 0 0 rem(2) $blue-alt-light inset; float: left; - font-size: rem(24); + font-size: rem(18); font-weight: 400; height: rem(45); line-height: rem(45); @@ -65,7 +65,7 @@ span { color: $blue-alt; - font-size: rem(24); + font-size: rem(18); } } @@ -137,6 +137,10 @@ .pagination-ellipsis { margin: rem(4) rem(0); + + span { + font-size: rem(24); + } } li.hide-on-mobile { @@ -152,6 +156,7 @@ } .pagination-link { + font-size: rem(24); height: rem(53); line-height: rem(53); margin: 0 rem(13); @@ -164,15 +169,15 @@ @include breakpoint-down(xs) { .pagination { .pagination-link { - font-size: rem(18); height: rem(42); line-height: rem(43); margin: rem(10) rem(3); width: rem(42); } - .pagination-ellipsis span { - font-size: rem(18); + .pagination-next, + .pagination-previous { + line-height: rem(40); } } } From 8a0783313688749bec42b28904f8ce629acad503 Mon Sep 17 00:00:00 2001 From: TeddTech Date: Tue, 8 Sep 2020 17:35:33 -0700 Subject: [PATCH 4/5] fix: add different pagination line height for desktop view --- src/scss/components/_pagination.scss | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/scss/components/_pagination.scss b/src/scss/components/_pagination.scss index 383942cc1..64015ce3e 100644 --- a/src/scss/components/_pagination.scss +++ b/src/scss/components/_pagination.scss @@ -128,6 +128,7 @@ @include breakpoint-up(lg) { .pagination { + line-height: rem(35); margin-top: rem(62); .previous, @@ -162,18 +163,6 @@ margin: 0 rem(13); width: rem(53); } - } -} - -// This media query breakpoint comes the width of the Galaxy Fold screen. -@include breakpoint-down(xs) { - .pagination { - .pagination-link { - height: rem(42); - line-height: rem(43); - margin: rem(10) rem(3); - width: rem(42); - } .pagination-next, .pagination-previous { @@ -181,3 +170,10 @@ } } } + +// This media query breakpoint comes the width of the Galaxy Fold screen. +@include breakpoint-down(xs) { + .pagination .pagination-link { + margin: rem(10) rem(3); + } +} From 7666ab43315a5bed06f07fe56342d59e2a95ab8e Mon Sep 17 00:00:00 2001 From: TeddTech Date: Tue, 8 Sep 2020 17:46:20 -0700 Subject: [PATCH 5/5] fix: made left and right margin value auto for desktop --- src/scss/components/_pagination.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/scss/components/_pagination.scss b/src/scss/components/_pagination.scss index 64015ce3e..d5e67c944 100644 --- a/src/scss/components/_pagination.scss +++ b/src/scss/components/_pagination.scss @@ -129,6 +129,8 @@ @include breakpoint-up(lg) { .pagination { line-height: rem(35); + margin-left: auto; + margin-right: auto; margin-top: rem(62); .previous,