Skip to content

Commit

Permalink
#develop Listed @ibg/types as a dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
bennobuilder committed Jul 8, 2024
1 parent e3b6ef3 commit 35d0ca2
Show file tree
Hide file tree
Showing 8 changed files with 43 additions and 20 deletions.
11 changes: 11 additions & 0 deletions .changeset/shaggy-ties-cheer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'feature-logger': patch
'@ibg/openapi-router': patch
'feature-fetch': patch
'feature-state': patch
'feature-form': patch
---

Listed `@ibg/types` as a dependency to ensure it's automatically installed for consumers, preventing issues like `any` types for `feature-x` packages due to missing `TUnionToIntersection`.

For more details: [Microsoft/types-publisher/issues/81](https://github.com/Microsoft/types-publisher/issues/81).
12 changes: 12 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,18 @@ For specific packages, additional fields should be included as shown below. Note
}
```

## Q and A

### Why is `@ibg/types` listed as a dependency in some packages?

`@ibg/types` is listed as a dependency to ensure it's automatically installed for consumers, preventing issues like `any` types for `feature-x` packages due to missing `TUnionToIntersection`.

For more details: [Microsoft/types-publisher/issues/81](https://github.com/Microsoft/types-publisher/issues/81).

Alternatives:
- Move `TUnionToIntersection` into each package
- Enforce `@ibg/types` as a `peerDependency`

## 📄 License

By contributing to inbeta.group, you agree that your contributions will be licensed under the license defined in [`LICENSE.md`](./LICENSE.md).
Expand Down
2 changes: 1 addition & 1 deletion packages/feature-fetch/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@
},
"homepage": "https://inbeta.group/?source=package-json",
"dependencies": {
"@ibg/types": "workspace:*",
"@ibg/utils": "workspace:*",
"ts-results-es": "4.2.0"
},
"devDependencies": {
"@ibg/config": "workspace:*",
"@ibg/types": "workspace:*",
"@types/node": "^20.14.1",
"@types/url-parse": "^1.4.11",
"msw": "^2.3.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/feature-form/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@
},
"homepage": "https://inbeta.group/?source=github",
"dependencies": {
"@ibg/types": "workspace:*",
"@ibg/utils": "workspace:*",
"feature-state": "workspace:*",
"validation-adapter": "workspace:*"
},
"devDependencies": {
"@ibg/config": "workspace:*",
"@ibg/types": "workspace:*",
"@types/node": "^20.14.1"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/feature-logger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
},
"homepage": "https://inbeta.group/?source=github",
"dependencies": {
"@ibg/types": "workspace:*",
"@ibg/utils": "workspace:*"
},
"devDependencies": {
"@ibg/config": "workspace:*",
"@ibg/types": "workspace:*",
"@types/node": "^20.14.1"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/feature-state/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
},
"homepage": "https://inbeta.group/?source=github",
"dependencies": {
"@ibg/types": "workspace:*",
"@ibg/utils": "workspace:*"
},
"devDependencies": {
"@ibg/config": "workspace:*",
"@ibg/types": "workspace:*",
"@types/node": "^20.14.1"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/openapi-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
},
"homepage": "https://inbeta.group/?source=package-json",
"dependencies": {
"@ibg/types": "workspace:*",
"validation-adapter": "workspace:*"
},
"devDependencies": {
"@ibg/config": "workspace:*",
"@ibg/types": "workspace:*",
"@types/express": "^4.17.21",
"@types/express-serve-static-core": "^4.19.5",
"@types/node": "^20.14.10",
Expand Down
30 changes: 15 additions & 15 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 35d0ca2

Please sign in to comment.