-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a single JSON library #100
Comments
Hi @aalmiray, do you think you could submit a patch converging on one library? We essentially have two implementations under the hood due to a major refactor a while ago and looks like this was a side effect. Thanks! |
Sure. My personal preference would be Jackson as stated before. Does that match the goals of the project? |
When I implemented the new version of the client it was my preference to use Jackson too. However, we did not remove gson for "compatibility" reasons. We could spend some time making sure the gson generated JSON matches the one from Jackson, but I think it requires the addition of more detail unit tests (Especially for the legacy stuff) |
I think switching everything over to jackson is fine. @aalmiray do you want to take a stab at it and working on parts that may have some issues with the switch? |
@adityasaky Yes, I can work on a spike in the coming weeks. I may come back with questions 😅 |
At the moment both Jackson and GSON are configured as dependencies. It would be better if there was only one dependency for processing JSON. Hopeful Jackson will be the chosen one.
in-toto-java/pom.xml
Lines 57 to 74 in 73afcb4
The text was updated successfully, but these errors were encountered: