Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

Market selection #7

Open
murphykobe opened this issue Aug 19, 2018 · 3 comments
Open

Market selection #7

murphykobe opened this issue Aug 19, 2018 · 3 comments

Comments

@murphykobe
Copy link

I cannot use market selector, seems not working well, does grailed changed their selector for this?
screen shot 2018-08-19 at 7 02 25 pm

@murphykobe
Copy link
Author

I think this line should be index = 2 not 0

var isMarketActive = classes.split(" ").indexOf("active") == 2;

As the class name = "active-indicator strata-select-item active"

@imsteev
Copy link
Owner

imsteev commented Aug 22, 2018

I am considering a rewrite for v2. will try to make the selectors as generic as possible, not having to rely on hardcoded constants.

@zacharypodbela
Copy link
Contributor

Had the same issue. I've opened a PR that fixes this by instead checking for lacked of an "active" class. (index != -1). #9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants