JOSS REVIEW: Missing dependency (pypulseq==0.0.3)

[mathieuboudreau]

This is for openjournals/joss-reviews#1637

Per your installation instructions, I tried to installed all your requirements (using pip install -e .), however I encountered a missing dependency:

Collecting pypulseq==0.0.3 (from virtual-scanner==1.0.21)
  ERROR: Could not find a version that satisfies the requirement pypulseq==0.0.3 (from virtual-scanner==1.0.21) (from versions: 1.0.0, 1.2.1)
ERROR: No matching distribution found for pypulseq==0.0.3 (from virtual-scanner==1.0.21)

It appears that this version of pypulseq is not available on pypi: https://pypi.org/project/pypulseq/#history

Can you update your requirements file, or resolve this in another way?

[mathieuboudreau]

Digging into this a bit more, I see that your requirements.txt file in your master correctly suggests version 1.0.0 of pypulseq, so it's not quite clear to me why it's trying to pull version 0.0.3. I'll look into this and report back.

[mathieuboudreau]

The conflict is in your setup.py file, which doesn't call your requirements.txt file.

virtual-scanner/setup.py

Line 42 in 12b6a47

'pypulseq==0.0.3',

[mathieuboudreau]

There is a mismatch between your setup.py file and your requirements.txt file. At the very least, this should be cleaned up so they match, but ideally you wouldn't duplicate these.

You could either suggest that the user installs the requirements.txt file using pip install -r requirements.txt, or create a setup.py file structured like this one, which calls the requirements.txt file on line 36 using lines 14-17.

[mathieuboudreau]

Note that this also bug is present while installing using pypi using pip install virtual-scanner, so I would recommend using the setup.py solution I recommend above if you plan on hosting on pypi.

[sravan953]

There is a mismatch between your setup.py file and your requirements.txt file. At the very least, this should be cleaned up so they match, but ideally you wouldn't duplicate these.

You could either suggest that the user installs the requirements.txt file using pip install -r requirements.txt, or create a setup.py file structured like this one, which calls the requirements.txt file on line 36 using lines 14-17.

Was not aware of this, thank you very much! :)
Fixed in f3718ac.