Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added safeguard against 847. Make sure debug stats are always printed, even on error. #889

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Added safeguard against 847. Make sure debug stats are always printed, even on error. #889

merged 1 commit into from
Mar 19, 2019

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Mar 5, 2019

Debugs: #874

TODO in next PRs:

  • Test gRPC panic recovery... it seems to not work.
  • Add logging interceptors. At least for error logging.

CC @mjd95 @GiedriusS

Signed-off-by: Bartek Plotka [email protected]

GiedriusS
GiedriusS approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will guard against that problem. It incurs an extra performance hit but we need to be defensive here. Above all, it will be useful to find out why that's happening

@bwplotka bwplotka merged commit 166d54e into master Mar 19, 2019
@bwplotka bwplotka deleted the issue874 branch March 19, 2019 08:25
@bwplotka bwplotka mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

@domgreen domgreen Awaiting requested review from domgreen

@improbable-ludwik improbable-ludwik Awaiting requested review from improbable-ludwik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwplotka @GiedriusS