-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI #560
Comments
Here is my spike on making Travis working for this repo: In order to make Travis CI working we need to make the tests run on Linux, currently it seems the I have tried running the QUnit tests using Karma locally, but the complexity and amount of code seems too high. Therefore, I am looking into a simpler solution that doesn't require the project to figure out how to make the tests work locally in Windows, Mac and Linux Ubuntu (for Travis CI). I have tried drone.io as @bartaz mentioned in his comment, but after I created the account I noticed they use outdated node versions I have tried using gulp, so that we can find some plugin that can run the tests out of the box inside a service (like Sauce Labs*). I have found ➜ impress.js git:(ci) ✗ ./node_modules/.bin/gulp test-integration
[16:47:16] Using gulpfile ~/Git/impress.js/gulpfile.js
[16:47:16] Starting 'test-integration'...
[16:47:19] Testing core_tests.html
[16:47:19] Test failed: Initialization: Attributes
[16:47:19] Failed assertion: canvas.style.transform initialized correctly, expected: rotateZ(0deg) rotateY(0deg) rotateX(0deg) translate3d(1000px, 0px, 0px), but was: undefined
[16:47:19] at file:////Users/fagnerbrack/Git/impress.js/test/core_tests.js:50:25
[16:47:19] Failed assertion: canvas.style.transformOrigin initialized correctly, expected: left top 0px, but was: undefined
[16:47:19] at file:////Users/fagnerbrack/Git/impress.js/test/core_tests.js:54:25
[16:47:19] Failed assertion: canvas.style.transformStyle initialized correctly, expected: preserve-3d, but was: undefined
[16:47:19] at file:////Users/fagnerbrack/Git/impress.js/test/core_tests.js:58:25
[16:47:19]
[16:47:19] Took 3071ms to run 22 tests. 19 passed, 3 failed.
[16:47:19] gulp-qunit: ✖ QUnit assertions failed in core_tests.html
[16:47:19] 'test-integration' errored after 3.47 s
[16:47:19] Error in plugin 'gulp-qunit'
Message:
Command failed: /Users/fagnerbrack/Git/impress.js/node_modules/phantomjs2/lib/phantom/bin/phantomjs /Users/fagnerbrack/Git/impress.js/node_modules/qunit-phantomjs-runner/runner.js file:////Users/fagnerbrack/Git/impress.js/test/core_tests.html
Details:
killed: false
code: 1
signal: null
cmd: /Users/fagnerbrack/Git/impress.js/node_modules/phantomjs2/lib/phantom/bin/phantomjs /Users/fagnerbrack/Git/impress.js/node_modules/qunit-phantomjs-runner/runner.js file:////Users/fagnerbrack/Git/impress.js/test/core_tests.html I am considering creating a new gulp plugin or make a PR in existing ones for running chrome instead of PhantomJS (jonkemp/gulp-qunit#31), I am just not sure the amount of work to get that thing done. Any useful ideas on how to make tests working in Linux Ubuntu (for Travis CI) with the least amount of effort will be much appreciated. * The Sauce approach is how it is already being done with js-cookie, although it uses grunt instead of gulp and Sauce Labs is known to become unstable sometimes (even bootstrap is looking for changing it, see twbs/bootstrap#18754). |
After #566 this might become easier. I have received some tips to use CircleCI instead of Travis, seems to be better at running Chrome. Need to take a look into that. |
Added some PR's related to this, @FagnerMartinsBrack |
Fixed by #568. |
We need to add a continuous integration service that runs the test whenever there is a new Pull Request. Only one, just to start, probably Travis CI that is free for Open Source.
The text was updated successfully, but these errors were encountered: