-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Enhance API endpoint to support additional filters #7285
Open
pulsovi
wants to merge
14
commits into
impress-org:develop
Choose a base branch
from
pulsovi:filter/make-list_table-extendable
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New: Enhance API endpoint to support additional filters #7285
pulsovi
wants to merge
14
commits into
impress-org:develop
from
pulsovi:filter/make-list_table-extendable
+303
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
pulsovi
force-pushed
the
filter/make-list_table-extendable
branch
from
August 5, 2024 13:05
3579553
to
b4f5184
Compare
pulsovi
changed the title
New Feat: Admin List Tables - allow third party plugin to add filters
New: Enhance API endpoint to support additional filters
Aug 9, 2024
use parentheses on OR WHERE clause
pulsovi
force-pushed
the
filter/make-list_table-extendable
branch
from
August 9, 2024 11:57
b6d9e43
to
eeac823
Compare
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New: Enhance API endpoint to support additional filters
Resolves #7484
Description
Enhances the
Give\Donations\Endpoints\ListDonations
API endpoint to support additional filters, providing the necessary hooks for compatibility with third party add-ons / snippets.The main goal is to extend the flexibility of the Donations\ListTable in the admin interface, allowing for the integration of new filters, such as filtering donations by donor ID.
Affects
Admin List Tables
Visuals
N/A
Testing Instructions
Tests already included in PR : see
tests/Unit/Donations/Endpoints/TestListDonations:testShouldAllowAddingFilters
To test the new hooks and extension points, add some JavaScript code on the front-end page (via a snippet):
Go to the
back office > Give > Donations
, new filter input added for Donor ID, lastname or firstname.To allow using filters that are not already managed by ListDonations
Pre-review Checklist
[-] Reviewed by the designer (if follows a design)